[llvm-branch-commits] [libcxx] f75bf71 - [libc++] Use TARGET_FILE instead of TARGET_SONAME_FILE when generating ABI lists

Louis Dionne via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Dec 11 09:17:08 PST 2020


Author: Louis Dionne
Date: 2020-12-11T12:12:40-05:00
New Revision: f75bf712deecc1be157f7ba6e2fd80922942546c

URL: https://github.com/llvm/llvm-project/commit/f75bf712deecc1be157f7ba6e2fd80922942546c
DIFF: https://github.com/llvm/llvm-project/commit/f75bf712deecc1be157f7ba6e2fd80922942546c.diff

LOG: [libc++] Use TARGET_FILE instead of TARGET_SONAME_FILE when generating ABI lists

TARGET_SONAME_FILE isn't valid on Windows, and TARGET_FILE should achieve
the same results.

Differential Revision: https://reviews.llvm.org/D92856

Added: 
    

Modified: 
    libcxx/lib/abi/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxx/lib/abi/CMakeLists.txt b/libcxx/lib/abi/CMakeLists.txt
index e25c09b7a348..3d19c0bd16f2 100644
--- a/libcxx/lib/abi/CMakeLists.txt
+++ b/libcxx/lib/abi/CMakeLists.txt
@@ -57,7 +57,7 @@ if (TARGET cxx_shared)
       "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/sym_
diff .py"
           --only-stdlib-symbols
           --strict "${abi_list_file}"
-          $<TARGET_SONAME_FILE:cxx_shared>
+          $<TARGET_FILE:cxx_shared>
       DEPENDS cxx_shared
       COMMENT "Testing libc++'s exported symbols against the ABI list")
   else()
@@ -67,7 +67,7 @@ if (TARGET cxx_shared)
   add_custom_target(generate-cxx-abilist
     COMMAND "${Python3_EXECUTABLE}" "${LIBCXX_SOURCE_DIR}/utils/generate_abi_list.py"
             --output "${abi_list_file}"
-            "$<TARGET_SONAME_FILE:cxx_shared>"
+            "$<TARGET_FILE:cxx_shared>"
     DEPENDS cxx_shared
     COMMENT "Generating the ABI list file for configuration ${abi_list_identifier}")
 else()


        


More information about the llvm-branch-commits mailing list