[llvm-branch-commits] [lld] 349d5c9 - [lld-macho] Disable some tests that are failing on Windows

Jez Ng via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Dec 10 17:58:40 PST 2020


Author: Jez Ng
Date: 2020-12-10T17:54:23-08:00
New Revision: 349d5c9cf79803187a2e1e2a080a8e460d03cf76

URL: https://github.com/llvm/llvm-project/commit/349d5c9cf79803187a2e1e2a080a8e460d03cf76
DIFF: https://github.com/llvm/llvm-project/commit/349d5c9cf79803187a2e1e2a080a8e460d03cf76.diff

LOG: [lld-macho] Disable some tests that are failing on Windows

lto-object-path.ll, like stabs.s, is disabled on Windows as the path
separators make it difficult to write a test that works across
platforms.

This diff also disables implicit-dylibs.s on Windows as we seem to emit
LC_LOAD_DYLIBs in a different order on that platform. This seems like a
bug in LLD that needs to be addressed (in a future diff).

Added: 
    

Modified: 
    lld/test/MachO/implicit-dylibs.s
    lld/test/MachO/lto-object-path.ll

Removed: 
    


################################################################################
diff  --git a/lld/test/MachO/implicit-dylibs.s b/lld/test/MachO/implicit-dylibs.s
index 2030da423020..21084b50006b 100644
--- a/lld/test/MachO/implicit-dylibs.s
+++ b/lld/test/MachO/implicit-dylibs.s
@@ -1,4 +1,6 @@
 # REQUIRES: x86
+## FIXME: We appear to emit LC_LOAD_DYLIBs in a 
diff erent order on Windows.
+# UNSUPPORTED: system-windows
 # RUN: rm -rf %t; split-file %s %t
 # RUN: mkdir -p %t/usr/lib/system
 

diff  --git a/lld/test/MachO/lto-object-path.ll b/lld/test/MachO/lto-object-path.ll
index b362bf45b133..b21b38f23527 100644
--- a/lld/test/MachO/lto-object-path.ll
+++ b/lld/test/MachO/lto-object-path.ll
@@ -1,4 +1,5 @@
 ; REQUIRES: x86
+; UNSUPPORTED: system-windows
 
 ; RUN: rm -rf %t; mkdir %t
 ; RUN: llvm-as %s -o %t/test.o


        


More information about the llvm-branch-commits mailing list