[llvm-branch-commits] [llvm] c54d827 - [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator

Stefan Gränitz via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Dec 8 02:03:12 PST 2020


Author: Stefan Gränitz
Date: 2020-12-08T10:58:20+01:00
New Revision: c54d827fdb12d033dca2155c416f02791fc86786

URL: https://github.com/llvm/llvm-project/commit/c54d827fdb12d033dca2155c416f02791fc86786
DIFF: https://github.com/llvm/llvm-project/commit/c54d827fdb12d033dca2155c416f02791fc86786.diff

LOG: [Orc] Two small fixes in TPCDynamicLibrarySearchGenerator

There is one result per lookup symbol, so we have to advance the result iterator no matter whether it's NULL or not.
MissingSymbols variable is unused.

Reviewed By: lhames

Differential Revision: https://reviews.llvm.org/D91707

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/TPCDynamicLibrarySearchGenerator.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/TPCDynamicLibrarySearchGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/TPCDynamicLibrarySearchGenerator.cpp
index f275c634a6d5..80d8f34ea447 100644
--- a/llvm/lib/ExecutionEngine/Orc/TPCDynamicLibrarySearchGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TPCDynamicLibrarySearchGenerator.cpp
@@ -50,12 +50,13 @@ Error TPCDynamicLibrarySearchGenerator::tryToGenerate(
   assert(Result->front().size() == LookupSymbols.size() &&
          "Result has incorrect number of elements");
 
-  SymbolNameVector MissingSymbols;
   auto ResultI = Result->front().begin();
-  for (auto &KV : LookupSymbols)
+  for (auto &KV : LookupSymbols) {
     if (*ResultI)
       NewSymbols[KV.first] =
-          JITEvaluatedSymbol(*ResultI++, JITSymbolFlags::Exported);
+          JITEvaluatedSymbol(*ResultI, JITSymbolFlags::Exported);
+    ResultI++;
+  }
 
   // If there were no resolved symbols bail out.
   if (NewSymbols.empty())


        


More information about the llvm-branch-commits mailing list