[llvm-branch-commits] [llvm] ccc5160 - Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable.

Douglas Yung via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Dec 7 16:48:17 PST 2020


Author: Douglas Yung
Date: 2020-12-07T16:36:58-08:00
New Revision: ccc5160df100663630329e2e544fc04dd126f88f

URL: https://github.com/llvm/llvm-project/commit/ccc5160df100663630329e2e544fc04dd126f88f
DIFF: https://github.com/llvm/llvm-project/commit/ccc5160df100663630329e2e544fc04dd126f88f.diff

LOG: Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable.

Our internal build bot hit a failure in llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
because the test was checking for an error message that is emitted when a pdb file is
missing. But when the drive is mapped to a removalable drive (such as a DVD drive) in
Windows, you get a different error message which causes the test to fail.

This fixes the test by changing the drive the missing pdb is expected to be on to C:\
instead of D:\ as that is the drive historically used to install Windows and thus
if present should be a hard drive.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D92787

Added: 
    

Modified: 
    llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe b/llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe
index 320e1f30e582..93aa8a788b96 100644
Binary files a/llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe and b/llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe 
diff er


        


More information about the llvm-branch-commits mailing list