[llvm-branch-commits] [clang] 7fc9f12 - Merging r372281:

Tom Stellard via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Nov 27 11:56:22 PST 2019


Author: Serge Guelton
Date: 2019-11-27T11:28:33-08:00
New Revision: 7fc9f129f80f192bd5ed73e9b94ffc59803c17fc

URL: https://github.com/llvm/llvm-project/commit/7fc9f129f80f192bd5ed73e9b94ffc59803c17fc
DIFF: https://github.com/llvm/llvm-project/commit/7fc9f129f80f192bd5ed73e9b94ffc59803c17fc.diff

LOG: Merging r372281:

------------------------------------------------------------------------
r372281 | serge_sans_paille | 2019-09-18 17:54:40 -0700 (Wed, 18 Sep 2019) | 8 lines

Initialize all fields in ABIArgInfo.

Due to usage of an uninitialized fields, we end up with
a Conditional jump or move depends on uninitialised value

Fixes https://bugs.llvm.org/show_bug.cgi?id=40547

Commited on behalf of Martin Liska <mliska at suse.cz>
------------------------------------------------------------------------

Added: 
    

Modified: 
    clang/include/clang/CodeGen/CGFunctionInfo.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/CodeGen/CGFunctionInfo.h b/clang/include/clang/CodeGen/CGFunctionInfo.h
index 1f81072e23d0..5069d9af42a3 100644
--- a/clang/include/clang/CodeGen/CGFunctionInfo.h
+++ b/clang/include/clang/CodeGen/CGFunctionInfo.h
@@ -109,14 +109,12 @@ class ABIArgInfo {
     UnpaddedCoerceAndExpandType = T;
   }
 
-  ABIArgInfo(Kind K)
-      : TheKind(K), PaddingInReg(false), InReg(false) {
-  }
-
 public:
-  ABIArgInfo()
+  ABIArgInfo(Kind K = Direct)
       : TypeData(nullptr), PaddingType(nullptr), DirectOffset(0),
-        TheKind(Direct), PaddingInReg(false), InReg(false) {}
+        TheKind(K), PaddingInReg(false), InAllocaSRet(false),
+        IndirectByVal(false), IndirectRealign(false), SRetAfterThis(false),
+        InReg(false), CanBeFlattened(false), SignExt(false) {}
 
   static ABIArgInfo getDirect(llvm::Type *T = nullptr, unsigned Offset = 0,
                               llvm::Type *Padding = nullptr,


        


More information about the llvm-branch-commits mailing list