[llvm-branch-commits] [clang-tools-extra-branch] r366713 - Merging r366443:

[Hans Wennborg via llvm-branch-commits]

Author: hans
Date: Mon Jul 22 11:06:03 2019
New Revision: 366713

URL: http://llvm.org/viewvc/llvm-project?rev=366713&view=rev
Log:
Merging r366443:
------------------------------------------------------------------------
r366443 | sammccall | 2019-07-18 17:00:38 +0200 (Thu, 18 Jul 2019) | 1 line

[clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670
------------------------------------------------------------------------

Modified:
    clang-tools-extra/branches/release_90/   (props changed)
    clang-tools-extra/branches/release_90/clangd/refactor/tweaks/DumpAST.cpp

Propchange: clang-tools-extra/branches/release_90/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jul 22 11:06:03 2019
@@ -1 +1 @@
-/clang-tools-extra/trunk:366687
+/clang-tools-extra/trunk:366443,366687

Modified: clang-tools-extra/branches/release_90/clangd/refactor/tweaks/DumpAST.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/branches/release_90/clangd/refactor/tweaks/DumpAST.cpp?rev=366713&r1=366712&r2=366713&view=diff
==============================================================================
--- clang-tools-extra/branches/release_90/clangd/refactor/tweaks/DumpAST.cpp (original)
+++ clang-tools-extra/branches/release_90/clangd/refactor/tweaks/DumpAST.cpp Mon Jul 22 11:06:03 2019
@@ -128,6 +128,11 @@ public:
         TypeWithKeyword::getTagTypeKindName(Record->getTagKind()));
   }
   Intent intent() const override { return Info; }
+  // FIXME: this is interesting to most users. However:
+  //  - triggering is too broad (e.g. triggers on comments within a class)
+  //  - showMessage has inconsistent UX (e.g. newlines are stripped in VSCode)
+  //  - the output itself is a bit hard to decipher.
+  bool hidden() const override { return true; }
 
 private:
   const RecordDecl *Record = nullptr;