[llvm-branch-commits] [llvm-branch] r352580 - Revert "Rename llvm library from libLLVM-X.Y to libLLVM-X"

Tom Stellard via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 29 17:13:33 PST 2019


Author: tstellar
Date: Tue Jan 29 17:13:33 2019
New Revision: 352580

URL: http://llvm.org/viewvc/llvm-project?rev=352580&view=rev
Log:
Revert "Rename llvm library from libLLVM-X.Y to libLLVM-X"

We need the soname and symbol versions to includes the minor release
number for 7.1.0.

Modified:
    llvm/branches/release_70/cmake/modules/AddLLVM.cmake
    llvm/branches/release_70/docs/ReleaseNotes.rst
    llvm/branches/release_70/tools/llvm-config/CMakeLists.txt
    llvm/branches/release_70/tools/llvm-shlib/simple_version_script.map.in

Modified: llvm/branches/release_70/cmake/modules/AddLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_70/cmake/modules/AddLLVM.cmake?rev=352580&r1=352579&r2=352580&view=diff
==============================================================================
--- llvm/branches/release_70/cmake/modules/AddLLVM.cmake (original)
+++ llvm/branches/release_70/cmake/modules/AddLLVM.cmake Tue Jan 29 17:13:33 2019
@@ -83,7 +83,7 @@ function(add_llvm_symbol_exports target_
     # FIXME: Don't write the "local:" line on OpenBSD.
     # in the export file, also add a linker script to version LLVM symbols (form: LLVM_N.M)
     add_custom_command(OUTPUT ${native_export_file}
-      COMMAND echo "LLVM_${LLVM_VERSION_MAJOR} {" > ${native_export_file}
+      COMMAND echo "LLVM_${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR} {" > ${native_export_file}
       COMMAND grep -q "[[:alnum:]]" ${export_file} && echo "  global:" >> ${native_export_file} || :
       COMMAND sed -e "s/$/;/" -e "s/^/    /" < ${export_file} >> ${native_export_file}
       COMMAND echo "  local: *;" >> ${native_export_file}
@@ -500,7 +500,7 @@ function(llvm_add_library name)
         PROPERTIES
         # Since 4.0.0, the ABI version is indicated by the major version
         SOVERSION ${LLVM_VERSION_MAJOR}
-        VERSION ${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
+        VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX})
     endif()
   endif()
 
@@ -522,7 +522,7 @@ function(llvm_add_library name)
       if(${output_name} STREQUAL "output_name-NOTFOUND")
         set(output_name ${name})
       endif()
-      set(library_name ${output_name}-${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX})
+      set(library_name ${output_name}-${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX})
       set(api_name ${output_name}-${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}${LLVM_VERSION_SUFFIX})
       set_target_properties(${name} PROPERTIES OUTPUT_NAME ${library_name})
       llvm_install_library_symlink(${api_name} ${library_name} SHARED

Modified: llvm/branches/release_70/docs/ReleaseNotes.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_70/docs/ReleaseNotes.rst?rev=352580&r1=352579&r2=352580&view=diff
==============================================================================
--- llvm/branches/release_70/docs/ReleaseNotes.rst (original)
+++ llvm/branches/release_70/docs/ReleaseNotes.rst Tue Jan 29 17:13:33 2019
@@ -30,9 +30,6 @@ Non-comprehensive list of changes in thi
   is available on the Visual Studio Marketplace. The new integration
   supports Visual Studio 2017.
 
-* Libraries have been renamed from 7.0 to 7. This change also impacts
-  downstream libraries like lldb.
-
 * The LoopInstSimplify pass (``-loop-instsimplify``) has been removed.
 
 * Symbols starting with ``?`` are no longer mangled by LLVM when using the

Modified: llvm/branches/release_70/tools/llvm-config/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_70/tools/llvm-config/CMakeLists.txt?rev=352580&r1=352579&r2=352580&view=diff
==============================================================================
--- llvm/branches/release_70/tools/llvm-config/CMakeLists.txt (original)
+++ llvm/branches/release_70/tools/llvm-config/CMakeLists.txt Tue Jan 29 17:13:33 2019
@@ -37,7 +37,7 @@ set(LLVM_CFLAGS "${CMAKE_C_FLAGS} ${CMAK
 set(LLVM_CXXFLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_CXX_FLAGS_${uppercase_CMAKE_BUILD_TYPE}} ${COMPILE_FLAGS} ${LLVM_DEFINITIONS}")
 set(LLVM_BUILD_SYSTEM cmake)
 set(LLVM_HAS_RTTI ${LLVM_CONFIG_HAS_RTTI})
-set(LLVM_DYLIB_VERSION "${LLVM_VERSION_MAJOR}${LLVM_VERSION_SUFFIX}")
+set(LLVM_DYLIB_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}${LLVM_VERSION_SUFFIX}")
 set(LLVM_HAS_GLOBAL_ISEL "ON")
 
 # Use the C++ link flags, since they should be a superset of C link flags.

Modified: llvm/branches/release_70/tools/llvm-shlib/simple_version_script.map.in
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/release_70/tools/llvm-shlib/simple_version_script.map.in?rev=352580&r1=352579&r2=352580&view=diff
==============================================================================
--- llvm/branches/release_70/tools/llvm-shlib/simple_version_script.map.in (original)
+++ llvm/branches/release_70/tools/llvm-shlib/simple_version_script.map.in Tue Jan 29 17:13:33 2019
@@ -1 +1 @@
-LLVM_ at LLVM_VERSION_MAJOR@ { global: *; };
+LLVM_ at LLVM_VERSION_MAJOR@. at LLVM_VERSION_MINOR@ { global: *; };




More information about the llvm-branch-commits mailing list