[llvm-branch-commits] [llvm-branch] r106124 - /llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp

Jim Grosbach grosbach at apple.com
Wed Jun 16 11:34:04 PDT 2010


Author: grosbach
Date: Wed Jun 16 13:34:04 2010
New Revision: 106124

URL: http://llvm.org/viewvc/llvm-project?rev=106124&view=rev
Log:
revert 106123. Should have been on ToT, not Hermes.

Modified:
    llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp

Modified: llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp?rev=106124&r1=106123&r2=106124&view=diff
==============================================================================
--- llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp (original)
+++ llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp Wed Jun 16 13:34:04 2010
@@ -270,9 +270,6 @@
       }
 
       // If we decided we need a spill, do it.
-      // FIXME: Spilling this way is overkill, as it forces all uses of
-      // the value to be reloaded from the stack slot, even those that aren't
-      // in the unwind blocks. We should be more selective.
       if (NeedsSpill) {
         ++NumSpilled;
         DemoteRegToStack(*Inst, true);





More information about the llvm-branch-commits mailing list