[llvm-branch-commits] [llvm-branch] r106123 - /llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp

[Jim Grosbach]

Author: grosbach
Date: Wed Jun 16 13:24:34 2010
New Revision: 106123

URL: http://llvm.org/viewvc/llvm-project?rev=106123&view=rev
Log:
add FIXME

Modified:
    llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp

Modified: llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp?rev=106123&r1=106122&r2=106123&view=diff
==============================================================================
--- llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp (original)
+++ llvm/branches/Apple/Hermes/lib/CodeGen/SjLjEHPrepare.cpp Wed Jun 16 13:24:34 2010
@@ -270,6 +270,9 @@
       }
 
       // If we decided we need a spill, do it.
+      // FIXME: Spilling this way is overkill, as it forces all uses of
+      // the value to be reloaded from the stack slot, even those that aren't
+      // in the unwind blocks. We should be more selective.
       if (NeedsSpill) {
         ++NumSpilled;
         DemoteRegToStack(*Inst, true);