[lldb-dev] [cfe-dev] [RFC] Deprecate email code reviews in favor of Phabricator
James Henderson via lldb-dev
lldb-dev at lists.llvm.org
Tue May 4 07:02:38 PDT 2021
The github URL is not the "rG" one being referred to here. If you wanted to
do a post-commit review on the commit, you'd go to
is a part of Phabricator. You can comment on this page, much in the same
way as you would a Dxxxxxx review.
On Tue, 4 May 2021 at 14:56, via lldb-dev <lldb-dev at lists.llvm.org> wrote:
> > You're right that doing post-commit reviews on Phabricator is not
> > seamless---the rG link is not included anywhere. Hopefully that could be
> > fixed with some Phabricator configuration tweaks, like sending the commit
> > email to the -commits list.
> The commit email has a URL: link, e.g. this recent one (which has no
> Dnnnnn review):
> Does that take you to a different place than the rG link would?
> Seems like they ought to go to the same place.
> lldb-dev mailing list
> lldb-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-dev