<div dir="ltr">The github URL is not the "rG" one being referred to here. If you wanted to do a post-commit review on the commit, you'd go to <a href="https://reviews.llvm.org/rGb04148f77713c92ee57b33b7b858ad18ce8d78e3">https://reviews.llvm.org/rGb04148f77713c92ee57b33b7b858ad18ce8d78e3</a>, which is a part of Phabricator. You can comment on this page, much in the same way as you would a Dxxxxxx review.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 4 May 2021 at 14:56, via lldb-dev <<a href="mailto:lldb-dev@lists.llvm.org">lldb-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> You're right that doing post-commit reviews on Phabricator is not<br>
> seamless---the rG link is not included anywhere.  Hopefully that could be<br>
> fixed with some Phabricator configuration tweaks, like sending the commit<br>
> email to the -commits list.<br>
<br>
The commit email has a URL: link, e.g. this recent one (which has no<br>
Dnnnnn review):<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3</a><br>
<br>
Does that take you to a different place than the rG link would?<br>
Seems like they ought to go to the same place.<br>
--paulr<br>
<br>
_______________________________________________<br>
lldb-dev mailing list<br>
<a href="mailto:lldb-dev@lists.llvm.org" target="_blank">lldb-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev</a><br>
</blockquote></div>