[lldb-dev] Xcode builds

[Todd Fiala]

Attached is my preprocessed ArchSpec.cpp from llvm/clang/lldb all synched
to TOT from a few moments ago (r207938).  I'm using Xcode Version 5.1
(5B130a).

I'm not seeing it pick up machine.h in the output.  The first time I see
MACHINE_TYPE_* is from llvm/Support/MachO.

Note this file doesn't have any local changes in it.


On Fri, May 2, 2014 at 2:08 PM, Todd Fiala <tfiala at google.com> wrote:

> > No one should be including it manually as we shouldn't have ANY code
> depending on platform specific headers. Try preprocessing your file and see
> who includes machine.h.
>
> Will do.
>
>
> On Fri, May 2, 2014 at 1:17 PM, Greg Clayton <gclayton at apple.com> wrote:
>
>>
>> On May 2, 2014, at 1:02 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>> > On Fri, May 2, 2014 at 12:00 PM, Greg Clayton <gclayton at apple.com>
>> wrote:
>> > Looks like you are getting a conflict with the macros defined in:
>> >
>> > <mach/machine.h>
>> >
>> > and these are ruining the defines set in:
>> >
>> > "llvm/Support/MachO.h"
>> >
>> > So you aren't missing anything and I am not sure why things are
>> different for us. I thought this was fixed by adding an underscore in front
>> of all CPU_TYPE_XXX items in MachO.h that exactly matched macros in
>> machine.h... It is really lame that a header file in LLVM is using macros
>> that exactly match enums.
>> >
>> > Feature, not a bug.  IMO it's lame that <mach/machine.h> uses macros
>> instead of enums.  ;)
>>
>> I completely agree, but alas we are stuck with this on MacOSX.
>>
>> > Is <mach/machine.h> pulled in transitively, or is it an explicit
>> include?  If so, what's being used?  Can it be isolated to a single cpp
>> file?
>>
>> No one should be including it manually as we shouldn't have ANY code
>> depending on platform specific headers. Try preprocessing your file and see
>> who includes machine.h.
>>
>>
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>>
>
>
>
> --
> Todd Fiala | Software Engineer |  tfiala at google.com |  650-943-3180
>



-- 
Todd Fiala | Software Engineer | tfiala at google.com | 650-943-3180
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140504/fbb3cf7f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ArchSpec.preprocessed.cpp.bz2
Type: application/x-bzip2
Size: 196198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140504/fbb3cf7f/attachment.bin>