[lldb-dev] LLDB test executable architectures

[Greg Clayton]

If the logic is broken, please fix, but don't remove or simplify it just because it is complex. Make sure that if a platform (like darwin) supports both x86_64 and i386 binaries, that the tests run for both so we cover all bases and know if something fails for 32 or 64 bit. Sounds like on Windows you only want to run x86_64 for 64 bit machines or i386 for 32 bit machine right?

Just make sure Darwin runs both with what ever fix you make.

> On Jul 29, 2014, at 4:22 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Currently dotest.py contains the following logic to determine what architectures to compile the test executables as:
> 
>     if args.archs:
>         # architectures were specified on the command line, just use them
>     else:
>         if (platform_system == 'Darwin' or (platform_system == 'Linux' and compilers == ['clang'])) and platform_machine == 'x86_64':
>             archs = ['x86_64', 'i386']
>         else:
>             archs = [platform_machine]
> 
> Does anyone actually need this kind of complicated logic?  It's kind of magical and hand-wavy.  There's no indication of why it makes sense that Darwin+x64 system would default to running both x64 and x86 tests, or why linux gcc x64 would run only x64 tests but not x86 tests, even though linux clang x64 would run both sets of tests.
> 
> I'd like to simplify it if possible (partly because this logic is actually broken on Windows, so I need to revisit it anyway).  Is there any reason we can't just keep it as simple as "If it's on the command line, use it, otherwise default to running only the tests corresponding to the system platform?"
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev