[lldb-dev] LLDB test executable architectures

[Zachary Turner]

Currently dotest.py contains the following logic to determine what
architectures to compile the test executables as:

    if args.archs:
        # architectures were specified on the command line, just use them
    else:
        if (platform_system == 'Darwin' or (platform_system == 'Linux' and
compilers == ['clang'])) and platform_machine == 'x86_64':
            archs = ['x86_64', 'i386']
        else:
            archs = [platform_machine]

Does anyone actually need this kind of complicated logic?  It's kind of
magical and hand-wavy.  There's no indication of why it makes sense that
Darwin+x64 system would default to running both x64 and x86 tests, or why
linux gcc x64 would run only x64 tests but not x86 tests, even though linux
clang x64 would run both sets of tests.

I'd like to simplify it if possible (partly because this logic is actually
broken on Windows, so I need to revisit it anyway).  Is there any reason we
can't just keep it as simple as "If it's on the command line, use it,
otherwise default to running only the tests corresponding to the system
platform?"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140729/d984e163/attachment.html>