[lldb-dev] Hexagon patches for upstream

[Ed Maste]

On 21 July 2014 13:38, Deepak Panickal <deepak at codeplay.com> wrote:
> Hi,
>
> I have just committed the aforementioned patches.

Hi Deepak,

The change introduced several new warnings:

../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:272:29:
warning: format specifies type 'unsigned int' but the argument has
type 'lldb::addr_t' (aka 'unsigned long') [-Wformat]
    printf( "sp : %04x \n", sp );
                  ~~~~      ^~
                  %04lx
../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:300:21:
warning: unused variable 'argType' [-Wunused-variable]
        llvm::Type *argType = prototype.getFunctionParamType( i );
                    ^
../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:342:37:
warning: format specifies type 'unsigned int' but the argument has
type 'lldb::addr_t' (aka 'unsigned long') [-Wformat]
        printf( "\n0x%04x 0x%08x ", addr, data );
                     ~~~~           ^~~~
                     %04lx
../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:247:24:
warning: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
    for ( int i = 0; i < args.size( ); i++ )
                     ~ ^ ~~~~~~~~~~~~
../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:317:39:
warning: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
    for ( int i = nRegArgs, offs=0; i < args.size( ); i++ )
                                    ~ ^ ~~~~~~~~~~~~
../tools/lldb/source/Plugins/ABI/SysV-hexagon/ABISysV_hexagon.cpp:352:1:
warning: unused function 'ReadIntegerArgument' [-Wunused-function]
ReadIntegerArgument ( Scalar &scalar,
^
6 warnings generated.

../tools/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp:59:9:
warning: unused variable 'nSyms' [-Wunused-variable]
    int nSyms = symtab->GetNumSymbols( );
        ^
../tools/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp:61:24:
warning: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
    for ( int i = 0; i < symtab->GetNumSymbols( ); i++ )
                     ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
../tools/lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp:406:70:
warning: format specifies type 'unsigned int' but the argument has
type 'addr_t' (aka 'unsigned long') [-Wformat]
                log->Printf( "Found _rtld_debug structure @ 0x%08x",
structAddr );
                                                              ~~~~   ^~~~~~~~~~
                                                              %08lx
3 warnings generated.