[lldb-dev] [PATCH] Fix crash on Linux if sem_wait() is interrupted

[Andrew MacPherson]

Hi Greg, I've removed the goto from the patch but left it in the places
where it already existed in the ProcessMonitor, let me know if you would
like those updated too.

Cheers,
Andrew


On Fri, Jan 24, 2014 at 7:10 PM, Greg Clayton <gclayton at apple.com> wrote:

> Can we get rid of the "goto" statement and make it a "while(1)" or
> "for(;;)" like the first part of the fix?
>
> On Jan 24, 2014, at 6:10 AM, Andrew MacPherson <andrew.macp at gmail.com>
> wrote:
>
> > Fix a crash where if sem_wait is interrupted then
> ProcessMonitor::ServeOperation() will crash accessing an invalid
> monitor->m_operation pointer. The fix is taken from how this same case is
> already handled in the ProcessMonitor constructor.
> >
> > Thanks,
> > Andrew
> >
> <sem_wait.EINTR.Linux.patch>_______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140124/be7b89c0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sem_wait.EINTR.Linux-2.patch
Type: text/x-diff
Size: 1049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140124/be7b89c0/attachment.patch>