<div dir="ltr">Hi Greg, I've removed the goto from the patch but left it in the places where it already existed in the ProcessMonitor, let me know if you would like those updated too.<br><br>Cheers,<br>Andrew<br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jan 24, 2014 at 7:10 PM, Greg Clayton <span dir="ltr"><<a href="mailto:gclayton@apple.com" target="_blank">gclayton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Can we get rid of the "goto" statement and make it a "while(1)" or "for(;;)" like the first part of the fix?<br>
<div><div class="h5"><br>
On Jan 24, 2014, at 6:10 AM, Andrew MacPherson <<a href="mailto:andrew.macp@gmail.com">andrew.macp@gmail.com</a>> wrote:<br>
<br>
> Fix a crash where if sem_wait is interrupted then ProcessMonitor::ServeOperation() will crash accessing an invalid monitor->m_operation pointer. The fix is taken from how this same case is already handled in the ProcessMonitor constructor.<br>
><br>
> Thanks,<br>
> Andrew<br>
</div></div>> <sem_wait.EINTR.Linux.patch>_______________________________________________<br>
> lldb-dev mailing list<br>
> <a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev</a><br>
<br>
</blockquote></div><br></div>