[lldb-dev] A few build/portability fixes

[kirk.beitz at nokia.com]

Jai ++

i was about to submit the same thing you called to resolve_storinst.patch , and i think the person i've been working with will probably apply it.

i had turned on -pedantic as well, but got so many errors in my effort to get it building that i turned it back off for the time being.  but your trailing_commas_in_enums.patch looks fine to me, and perhaps it can get committed as is.

i see there was already a comment on your python patch ... no further comment from me either way.

++ kirk

On 2011-Feb-4, at 5:44 PM, ext Jai Menon wrote:

On Fri, Jan 28, 2011 at 10:09 PM, Jai Menon <jmenon86 at gmail.com<mailto:jmenon86 at gmail.com>> wrote:
Hello,

I think these should be harmless enough.

- Remove a bunch of trailing commas at the end of enumerated lists.
Fixes compilation with -fpedantic (and is more valid c++ anyway)

- Factor some harcoded python paths/flags into make variables. This allows users
to override these when building in other "environments". The correct
way, of course,
is to have the buildsystem extract these from python-config, but I'm not sure if
that'll need to be in llvm's configure script or in lldb.

Any comments on this? Is there anything else I need to do to get these applied?

--
Jai Menon
_______________________________________________
lldb-dev mailing list
lldb-dev at cs.uiuc.edu<mailto:lldb-dev at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev


++ kirk beitz : nokia : austin + san diego : kirk.beitz at nokia.com<mailto:kirk.beitz at nokia.com> ++



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20110205/401081ce/attachment.html>