<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Jai ++</div><div><br></div><div>i was about to submit the same thing you called to resolve_storinst.patch , and i think the person i've been working with will probably apply it.</div><div><br></div><div>i had turned on -pedantic as well, but got so many errors in my effort to get it building that i turned it back off for the time being. but your trailing_commas_in_enums.patch looks fine to me, and perhaps it can get committed as is.</div><div><br></div><div>i see there was already a comment on your python patch ... no further comment from me either way.</div><div><br></div><div>++ kirk</div><br><div><div>On 2011-Feb-4, at 5:44 PM, ext Jai Menon wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Fri, Jan 28, 2011 at 10:09 PM, Jai Menon <<a href="mailto:jmenon86@gmail.com">jmenon86@gmail.com</a>> wrote:<br><blockquote type="cite">Hello,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I think these should be harmless enough.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- Remove a bunch of trailing commas at the end of enumerated lists.<br></blockquote><blockquote type="cite">Fixes compilation with -fpedantic (and is more valid c++ anyway)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- Factor some harcoded python paths/flags into make variables. This allows users<br></blockquote><blockquote type="cite">to override these when building in other "environments". The correct<br></blockquote><blockquote type="cite">way, of course,<br></blockquote><blockquote type="cite">is to have the buildsystem extract these from python-config, but I'm not sure if<br></blockquote><blockquote type="cite">that'll need to be in llvm's configure script or in lldb.<br></blockquote><br>Any comments on this? Is there anything else I need to do to get these applied?<br><br>-- <br>Jai Menon<br>_______________________________________________<br>lldb-dev mailing list<br><a href="mailto:lldb-dev@cs.uiuc.edu">lldb-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev<br></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="font-size: 11px; "><font class="Apple-style-span" face="Monaco"><span class="Apple-style-span" style="font-family: Helvetica; "><font class="Apple-style-span" face="Monaco"><br class="Apple-interchange-newline">++ kirk beitz : nokia : austin + san diego </font><span class="Apple-style-span" style="font-family: Monaco; ">: <a href="mailto:kirk.beitz@nokia.com">kirk.beitz@nokia.com</a> ++</span></span></font></div><div><br></div></span><br class="Apple-interchange-newline">
</div>
<br></body></html>