[lldb-dev] std::shared_ptr, RTTI, and LLDB

[Greg Clayton]

Is this the only place we are currently using RTTI? If so that is great. Jim Ingham should be able to get rid of this RTTI pretty easily early next week.


On Jun 11, 2010, at 8:46 PM, Eli Friedman wrote:

> On Fri, Jun 11, 2010 at 5:44 PM, Howard Hinnant <hhinnant at apple.com> wrote:
>> On Jun 11, 2010, at 12:20 PM, Chris Lattner wrote:
>> 
>>> 
>>> On Jun 10, 2010, at 6:06 PM, Greg Clayton wrote:
>>>> 
>>>> Howard, that would be great if you could trim this down for us.
>>> 
>>> Yep, thanks for doing this Howard!
>>> 
>>>> I don't believe we need anyting fancy (no RTTI, no weak_ptr (what I am aware of), no enable_shard_from_this). If you can send me a header that we can include into our Utility folder, I will check it in ASAP and see if we switch over to using it.
>>> 
>>> It would be great to drop this into include/llvm/ADT.  For example, we already have include/llvm/ADT/OwningPtr.h which is a close relation.
>> 
>> Here is a much trimmed down refcounted ptr.  The trimming reduces both dependencies and features.
> 
> Okay; I can't test this properly, but the implementation appears to be
> sufficient, although there appear to be a couple minor bugs (diff
> attached).
> 
> In terms of completely turning off RTTI, there are a few more changes
> required to eliminate the use of dynamic_cast; besides that, though,
> it appears quite feasible (hacky diff attached).
> 
> -Eli
> <lldbdiff.txt><sharingptrheaderdiff.txt>_______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev