[Lldb-commits] [lldb] [lldb] Fallback to comparing modules by their canonical paths (PR #210041)

[via lldb-commits]

================
@@ -3635,6 +3641,26 @@ Status Target::Launch(ProcessLaunchInfo &launch_info, Stream *stream) {
 
   FinalizeFileActions(launch_info);
 
+  // Preserve the path the user used to create this target when computing
----------------
jimingham wrote:

What is this for?  It's not really preserving anything.  This seems to handle the case where I put an executable file in my LaunchInfo that's different from the arg0 I also passed to the LaunchInfo.  I might do that, for instance, if I was debugging one of those binaries that get symlinked to a bunch of different names, and changes its behavior based on what arg0 was.  In that case, I might be switching arg0 around to invoke the different behaviors in a series of debug sessions in the same Target.  Why do you need to change the executable as well?  I think that would be surprising.

https://github.com/llvm/llvm-project/pull/210041