[Lldb-commits] [lldb] [lldb] Introduce DynamicRegisterInfo::RegisterSetWithStorage (PR #225555)

[Minsoo Choo via lldb-commits]

mchoo7 wrote:

I think the code is correct in general, but I wonder why we are not allowed to have `std::string name, shortname` in RegisterSet at the first place. If I understand correctly, this solution only applies to DynamicRegisterInfo and if someone wants to create new dynamic data structure with RegisterSet, they need create another `RegisterInfoWithStorage` implementation.

If I'm not missing some important context here, it would be better to have `std::string` members in RegisterSet so both statically and dynamically created RegisterSet have the same interface. If that is not possible due to technical reasons, I'm fine with this change.

https://github.com/llvm/llvm-project/pull/225555