[Lldb-commits] [lldb] [lldb][Windows] Skip assert frame recognizer tests on Windows (PR #224602)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

https://github.com/llvm/llvm-project/pull/224269 introduced the assert frame recognizers on Windows. This caused a regression on the Windows ARM64 build bot: `PECallFrameInfo` does not handle ARM64 yet.

This patch skips the test on arm64 Windows.

Tracking issue: https://github.com/llvm/llvm-project/issues/224600

---
Full diff: https://github.com/llvm/llvm-project/pull/224602.diff


2 Files Affected:

- (modified) lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (+1) 
- (modified) lldb/test/Shell/Recognizer/assert.test (+4) 


``````````diff
diff --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
index cb69b9881a514..985dd6b516bae 100644
--- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -947,6 +947,7 @@ std::unique_ptr<CallFrameInfo> ObjectFilePECOFF::CreateCallFrameInfo() {
   if (!data_dir_exception.vmaddr)
     return {};
 
+  // TODO: decode ARM64 .pdata/.xdata so optimized frameless code unwinds.
   if (m_coff_header.machine != llvm::COFF::IMAGE_FILE_MACHINE_AMD64)
     return {};
 
diff --git a/lldb/test/Shell/Recognizer/assert.test b/lldb/test/Shell/Recognizer/assert.test
index a8bb734e1bb02..6ecace774a1cb 100644
--- a/lldb/test/Shell/Recognizer/assert.test
+++ b/lldb/test/Shell/Recognizer/assert.test
@@ -6,6 +6,10 @@
 # debug a Linux target from another host.
 # UNSUPPORTED: system-linux, remote-linux
 #
+# https://github.com/llvm/llvm-project/issues/224600
+# ObjectFilePECOFF does not support ARM64 .pdata/.xdata.
+# UNSUPPORTED: target-windows && target-aarch64
+#
 # RUN: %clang_host -g -O0 %S/Inputs/assert.c -o %t.out
 # RUN: %lldb -b -s %s %t.out | FileCheck %s
 run

``````````

</details>


https://github.com/llvm/llvm-project/pull/224602