[Lldb-commits] [lldb] [lldb][Windows] Skip assert frame recognizer tests on Windows (PR #224602)
Charles Zablit via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 18 04:02:50 PDT 2026
https://github.com/charles-zablit created https://github.com/llvm/llvm-project/pull/224602
https://github.com/llvm/llvm-project/pull/224269 introduced the assert frame recognizers on Windows. This caused a regression on the Windows ARM64 build bot: `PECallFrameInfo` does not handle ARM64 yet.
This patch skips the test on arm64 Windows.
Tracking issue: https://github.com/llvm/llvm-project/issues/224600
>From 4ac818e65a4d3da5158da051ad5d80f667032649 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Fri, 18 Sep 2026 12:00:17 +0100
Subject: [PATCH] [lldb][Windows] Skip assert frame recognizer tests on Windows
---
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp | 1 +
lldb/test/Shell/Recognizer/assert.test | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
index cb69b9881a514..985dd6b516bae 100644
--- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -947,6 +947,7 @@ std::unique_ptr<CallFrameInfo> ObjectFilePECOFF::CreateCallFrameInfo() {
if (!data_dir_exception.vmaddr)
return {};
+ // TODO: decode ARM64 .pdata/.xdata so optimized frameless code unwinds.
if (m_coff_header.machine != llvm::COFF::IMAGE_FILE_MACHINE_AMD64)
return {};
diff --git a/lldb/test/Shell/Recognizer/assert.test b/lldb/test/Shell/Recognizer/assert.test
index a8bb734e1bb02..6ecace774a1cb 100644
--- a/lldb/test/Shell/Recognizer/assert.test
+++ b/lldb/test/Shell/Recognizer/assert.test
@@ -6,6 +6,10 @@
# debug a Linux target from another host.
# UNSUPPORTED: system-linux, remote-linux
#
+# https://github.com/llvm/llvm-project/issues/224600
+# ObjectFilePECOFF does not support ARM64 .pdata/.xdata.
+# UNSUPPORTED: target-windows && target-aarch64
+#
# RUN: %clang_host -g -O0 %S/Inputs/assert.c -o %t.out
# RUN: %lldb -b -s %s %t.out | FileCheck %s
run
More information about the lldb-commits
mailing list