[Lldb-commits] [lldb] [lldb-dap] Require LLVM thread support (PR #223604)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Anutosh Bhat (anutosh491)

<details>
<summary>Changes</summary>

Part of #<!-- -->223598. Discvoered this while working on [WasmBolt](https://github.com/anutosh491/WasmBolt)

`lldb-dap` unconditionally creates an event thread when initializing a debugger, but its CMake target is currently generated even when LLVM is configured with `LLVM_ENABLE_THREADS=OFF`.

This produces an `lldb-dap` executable that can be built but cannot actually start a debugging session. I encountered this while building LLDB with Emscripten, although the configuration issue is platform-independent.

This patch only adds the `lldb-dap` subdirectory when LLVM thread support is enabled.

---
Full diff: https://github.com/llvm/llvm-project/pull/223604.diff


1 Files Affected:

- (modified) lldb/tools/CMakeLists.txt (+3-1) 


``````````diff
diff --git a/lldb/tools/CMakeLists.txt b/lldb/tools/CMakeLists.txt
index d02a814f7383f..0323511173c93 100644
--- a/lldb/tools/CMakeLists.txt
+++ b/lldb/tools/CMakeLists.txt
@@ -9,7 +9,9 @@ add_subdirectory(lldb-test EXCLUDE_FROM_ALL)
 add_subdirectory(lldb-fuzzer EXCLUDE_FROM_ALL)
 
 add_lldb_tool_subdirectory(lldb-instr)
-add_lldb_tool_subdirectory(lldb-dap)
+if(LLVM_ENABLE_THREADS)
+  add_lldb_tool_subdirectory(lldb-dap)
+endif()
 add_lldb_tool_subdirectory(lldb-mcp)
 
 if (CMAKE_SYSTEM_NAME MATCHES "Darwin")

``````````

</details>


https://github.com/llvm/llvm-project/pull/223604