[Lldb-commits] [lldb] [lldb] Add accelerator plugin connection support (PR #201449)

[David Spickett via lldb-commits]

================
@@ -85,6 +85,28 @@ bool fromJSON(const llvm::json::Value &value,
               AcceleratorBreakpointHitArgs &data, llvm::json::Path path);
 llvm::json::Value toJSON(const AcceleratorBreakpointHitArgs &data);
 
+/// Information the client needs to create a reverse connection to an
----------------
DavidSpickett wrote:

You can call it whatever you want really, but it seems more akin to lldb-server's platform mode so I mostly want to make sure I'm not misunderstanding it.

* lldb-server spawns a new gdbserver
* lldb-server sends a https://lldb.llvm.org/resources/lldbgdbremote.html#qlaunchgdbserver-platform-extension with the details.
* lldb connects how it normally would

Which is unique in that the user doesn't type anything in themselves, but I wouldn't call that reversed.

Reverse sounds like the lldb is listening for connections from lldb-sever to lldb. Which we have an option for - https://lldb.llvm.org/man/lldb-server.html#cmdoption-lldb-server-reverse-connect, and you apparently use with a `listen://` URL (never used it myself).

If you mean "reverse" in that the spawning of the server is not initiated by lldb, I could understand that meaning. When you launch something with platform mode, you have to tell it, somehow, to do that. This accelerator stuff happens whenever it decides to do it.

https://github.com/llvm/llvm-project/pull/201449