[Lldb-commits] [lldb] [lldb] Add accelerator plugin connection support (PR #201449)

[David Spickett via lldb-commits]

================
@@ -2774,9 +2774,20 @@ packet when one is hit. Each breakpoint object has the following fields:
 Exactly one of `by_name` or `by_address` must be provided for each
 breakpoint.
 
+An `accelerator_action` may also include a `connect_info` object asking the
+client to create a new target and connect to a separate GDB server that
+serves the accelerator's state (for example a GPU debug stub). It has the
+following fields:
+
+| Key             | Type   | Description |
+|-----------------|--------|-------------|
+| `connect_url`   | string | Connection URL to connect to, as used by `process connect <url>`. |
+| `exe_path`      | string | Optional path to the executable to use when creating the accelerator target. If omitted, an empty target is created. |
+| `triple`        | string | Optional target triple to use as the architecture for the accelerator target. |
+| `synchronous`   | bool   | If true, the client waits for the accelerator process to finish initializing before continuing. |
----------------
DavidSpickett wrote:

How do we wait for the accelerator process to finish initializing?

Is this what you refer to in the text below:
> such as synchronization options for the accelerator process.

Just a first reaction, I wonder why this is field is a bool rather than a list of options or flags or whatever. Then the empty list would mean the equivalent of false here.

But just guessing from what you've said so far.

https://github.com/llvm/llvm-project/pull/201449