[Lldb-commits] [lldb] [lldb][debugserver] Arguments to kill(2) are reversed (PR #201226)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Jason Molenda (jasonmolenda)

<details>
<summary>Changes</summary>

This codepath is only executed as an attempt to clean up during a failed launch, so the reversed arguments were rarely actually used.

rdar://175507620

---
Full diff: https://github.com/llvm/llvm-project/pull/201226.diff


1 Files Affected:

- (modified) lldb/tools/debugserver/source/DNB.cpp (+1-1) 


``````````diff
diff --git a/lldb/tools/debugserver/source/DNB.cpp b/lldb/tools/debugserver/source/DNB.cpp
index 4febb1797def7..1f13e70a12546 100644
--- a/lldb/tools/debugserver/source/DNB.cpp
+++ b/lldb/tools/debugserver/source/DNB.cpp
@@ -379,7 +379,7 @@ nub_process_t DNBProcessLaunch(
         // point and get reparented to someone else and never go away.
         DNBLog("Could not get task port for process, sending SIGKILL and "
                "exiting.");
-        kill(SIGKILL, pid);
+        kill(pid, SIGKILL);
 
         if (err_str && err_len > 0) {
           if (launch_err.AsString()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/201226