[Lldb-commits] [lldb] [lldb] fix single-character token not underlined correctly in diagnostics (PR #197658)

via lldb-commits lldb-commits at lists.llvm.org
Fri May 15 02:21:37 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/unittests/Host/common/DiagnosticsRenderingTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
index 86664e72d..438592d07 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -280,11 +280,9 @@ public:
           // Find the range of the primary location.
           for (const auto &range : Info.getRanges()) {
             if (range.getBegin() != sloc)
-              continue
-            SourceLocation end = range.getEnd();
+              continue SourceLocation end = range.getEnd();
             if (range.isTokenRange())
-              end =
-                  clang::Lexer::getLocForEndOfToken(end, 0, sm, m_lang_opts);
+              end = clang::Lexer::getLocForEndOfToken(end, 0, sm, m_lang_opts);
             // FIXME: This is probably not handling wide characters correctly.
             unsigned end_col = sm.getSpellingColumnNumber(end);
             // Ignore ranges that span multiple lines.

``````````

</details>


https://github.com/llvm/llvm-project/pull/197658


More information about the lldb-commits mailing list