[Lldb-commits] [lldb] Reapply "[lldb] Do not refcount breakpoints in lldb-server" (#195858) (PR #196891)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett approved this pull request.

My understanding of the problem is:
```
Client: break on address A (bp1)
Server: sets break on address A (bp1)
Client: single step
Server: sets temporary breakpoint on address A (bp2), ... , removes bp2
```
Which leaves bp1 not actually set.

With the previous refcounting, bp1 gets set with refcount 1. Setting another on that address bumps it to 2, removing it puts it back to 1. So it worked out.

This PR handles it by reusing the existing breakpoint rather than setting a new one in the same place.

LGTM.

https://github.com/llvm/llvm-project/pull/196891