[Lldb-commits] [lldb] [lldb] Implement delayed breakpoints (PR #192971)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -1573,12 +1593,40 @@ Status Process::DisableBreakpointSiteByID(lldb::user_id_t break_id) {
   return error;
 }
 
+llvm::Error Process::ExecuteBreakpointSiteAction(BreakpointSite &site,
+                                                 BreakpointAction action) {
+  auto site_sp = site.shared_from_this();
+  std::unique_lock<std::recursive_mutex> guard(m_delayed_breakpoints_mutex);
+
+  // Ignore requests that won't change the Site status.
+  if (IsBreakpointSiteEnabled(*site_sp) == (action == BreakpointAction::Enable))
+    return llvm::Error::success();
+
+  if (!GetUseDelayedBreakpoints()) {
----------------
felipepiovezan wrote:

Yeah, when I removed the delayed boolean flag, the logic got inverted :( 

```diff
-  if (!force_now && GetUseDelayedBreakpoints()) {
+  if (!GetUseDelayedBreakpoints()) {
```
I need to come up with a test that looks at the packet log to catch up this kind of regression...

https://github.com/llvm/llvm-project/pull/192971