[Lldb-commits] [lldb] [lldb] Implement delayed breakpoints (PR #192971)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -2256,6 +2260,24 @@ class Process : public std::enable_shared_from_this<Process>,
         "error: {0} does not support disabling breakpoints", GetPluginName());
   }
 
+  /// Compare BreakpointSiteSPs by ID, so that iteration order is independent
+  /// of pointer addresses.
+  struct SiteIDCmp {
+    bool operator()(const lldb::BreakpointSiteSP &lhs,
+                    const lldb::BreakpointSiteSP &rhs) const {
+      return lhs->GetID() < rhs->GetID();
+    }
+  };
+  using BreakpointSiteToActionMap =
+      std::map<lldb::BreakpointSiteSP, BreakpointAction, SiteIDCmp>;
----------------
felipepiovezan wrote:

I don't think so, we need to keep the Site alive.
When a breakpoint site is scheduled for removal, it may be removed from the breakpoint site list, which would destroy it.

https://github.com/llvm/llvm-project/pull/192971