[Lldb-commits] [lldb] [lldb][Darwin] debugserver expedite new binary info, lldb use (PR #192754)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -1828,6 +1830,9 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo(
   if (dispatch_queue_t != LLDB_INVALID_ADDRESS)
     gdb_thread->SetQueueLibdispatchQueueAddress(dispatch_queue_t);
 
+  gdb_thread->SetNewlyAddedBinaries(added_binaries);
----------------
felipepiovezan wrote:

To be fair, any caller that passes a non-const reference to a vector should worry about the vector being emptied. So there are two possible outcomes here:

1. We propagate `const &` where applicable (in the LLVM world, this would be just an `ArrayRef` instead, as it works with all sorts of vector types)
2. We propagate `&&` everywhere so that callers explicitly give up ownership at the call site

I'm fine with either!

https://github.com/llvm/llvm-project/pull/192754