[Lldb-commits] [lldb] [lldb] Handle non-zero offsets from SP when computing initial CFA value (PR #192752)

[David Spickett via lldb-commits]

================
@@ -95,7 +95,13 @@ bool UnwindAssemblyInstEmulation::GetNonCallSiteUnwindPlanFromAssembly(
 
   // CreateFunctionEntryUnwind should have created the first row. If it doesn't,
   // then we are done.
-  if (unwind_plan.GetRowCount() == 0)
+  const UnwindPlan::Row *initial_row = unwind_plan.GetFirstRow();
+  if (!initial_row)
+    return false;
+
+  // Only isRegisterPlusOffset rule is currently supported.
----------------
DavidSpickett wrote:

Is it worth adding here what that rule is generally doing? Basically repeating what you said in the PR description for those who are reading this later in the context of the whole file rather than the one PR.

https://github.com/llvm/llvm-project/pull/192752