[Lldb-commits] [lldb] [lldb] Assert lack of trailing period or newlines in diagnostics (PR #191447)

[Jonas Devlieghere via lldb-commits]

================
@@ -33,6 +33,12 @@ static llvm::raw_ostream &note(Stream &strm) {
          << "note: ";
 }
 
+static llvm::StringRef validate(llvm::StringRef diagnostic) {
+  assert(!diagnostic.ends_with('\n') && !diagnostic.ends_with('.') &&
----------------
JDevlieghere wrote:

There are legitimate cases wheee the diagnostic starts with an uppercase letter, for example "DIE" or "Xcode".

https://github.com/llvm/llvm-project/pull/191447