[Lldb-commits] [lldb] [lldb] Assert lack of trailing period or newlines in diagnostics (PR #191447)

[Michael Buch via lldb-commits]

================
@@ -33,6 +33,12 @@ static llvm::raw_ostream &note(Stream &strm) {
          << "note: ";
 }
 
+static llvm::StringRef validate(llvm::StringRef diagnostic) {
+  assert(!diagnostic.ends_with('\n') && !diagnostic.ends_with('.') &&
+         "diagnostics should end without a period/newline");
+  return diagnostic.trim("\n.");
----------------
Michael137 wrote:

Should we add a comment saying why we still trim the characters (and why `\n`/`.` specifically)?

https://github.com/llvm/llvm-project/pull/191447