[Lldb-commits] [lldb] [lldb] LLDB_TEST_ARCH -> LLDB_TEST_TRIPLE (PR #191204)

[David Spickett via lldb-commits]

================
@@ -21,17 +21,11 @@ function(add_python_test_target name test_script args comment)
   add_dependencies(${name} lldb-test-depends)
 endfunction()
 
-# The default architecture with which to compile test executables is the
-# default LLVM target architecture, which itself defaults to the host
-# architecture.
-if(NOT LLDB_DEFAULT_TEST_ARCH)
-  string(REGEX MATCH "^[^-]*" LLDB_DEFAULT_TEST_ARCH ${LLVM_HOST_TRIPLE})
-endif ()
-
-# Allow the user to override the default by setting LLDB_TEST_ARCH
-set(LLDB_TEST_ARCH
-  ${LLDB_DEFAULT_TEST_ARCH}
-  CACHE STRING "Specify the architecture to run LLDB tests as (x86|x64).  Determines whether tests are compiled with -m32 or -m64")
+# The default triple with which to compile test executables is the
+# host triple.
+set(LLDB_TEST_TRIPLE
+  ${LLVM_HOST_TRIPLE}
+  CACHE STRING "Specify the triple to run LLDB tests with.")
 
----------------
DavidSpickett wrote:

Definitely, that's a good idea.

I assume https://lab.llvm.org/buildbot/#/builders/197/builds/15187/steps/7/logs/stdio is one of those builders.
```
cmake <...> -DLLVM_TARGET_TRIPLE=aarch64-unknown-linux-gnu <...> -DLLDB_TEST_ARCH=aarch64 <...>
```
When this lands, LLDB_TEST_ARCH would be unused which is just a warning not an error.

https://github.com/llvm/llvm-project/pull/191204