[Lldb-commits] [lldb] [lldb] LLDB_TEST_ARCH -> LLDB_TEST_TRIPLE (PR #191204)

[Vladimir Vereschaka via lldb-commits]

================
@@ -21,17 +21,11 @@ function(add_python_test_target name test_script args comment)
   add_dependencies(${name} lldb-test-depends)
 endfunction()
 
-# The default architecture with which to compile test executables is the
-# default LLVM target architecture, which itself defaults to the host
-# architecture.
-if(NOT LLDB_DEFAULT_TEST_ARCH)
-  string(REGEX MATCH "^[^-]*" LLDB_DEFAULT_TEST_ARCH ${LLVM_HOST_TRIPLE})
-endif ()
-
-# Allow the user to override the default by setting LLDB_TEST_ARCH
-set(LLDB_TEST_ARCH
-  ${LLDB_DEFAULT_TEST_ARCH}
-  CACHE STRING "Specify the architecture to run LLDB tests as (x86|x64).  Determines whether tests are compiled with -m32 or -m64")
+# The default triple with which to compile test executables is the
+# host triple.
+set(LLDB_TEST_TRIPLE
+  ${LLVM_HOST_TRIPLE}
+  CACHE STRING "Specify the triple to run LLDB tests with.")
 
----------------
vvereschaka wrote:

I would like to suggest using the LLVM target triple at first if it was specified (or LLVM_DEFAULT_TARGET_TRIPLE); otherwise LLVM_HOST_TRIPLE. I.e. something like this here:

```
if (NOT DEFINED LLDB_TEST_TRIPLE)
  if (DEFINED LLVM_TARGET_TRIPLE)
    set(_lldb_test_triple ${LLVM_TARGET_TRIPLE})
  else()
    set(_lldb_test_triple ${LLVM_HOST_TRIPLE})
  endif()
  
  set(LLDB_TEST_TRIPLE
    ${_lldb_test_triple}
    CACHE STRING "Specify the triple to run LLDB tests with.")
endif()

message(STATUS "LLDB test triple: ${LLDB_TEST_TRIPLE}")
```

it will handle the cross builds properly. Also I'll be able to smoothly transit the buildbot's cross lldb builders for these changes. 
Otherwise we need some transition period when both of those parameters are supported and we get a time to update and apply the buildbot confguration with new parameters.

https://github.com/llvm/llvm-project/pull/191204