[Lldb-commits] [lldb] [lldb] Fix: Disable shared build dir when testing with PDB (PR #190991)

[Michael Buch via lldb-commits]

Michael137 wrote:

> > I suspect we cant do that because the other STL tests rely on this setting to not share build directories too (it's not just for PDB)
> 
> Thanks for the note. That makes sense, yes. We have only one other case then. Should we still keep the implicit setting? One the one hand, this is an extra bit of logic in a general-purpose script for only a few tests. On the other hand, it makes sense for all PDB tests, because PDB regeneration is commonly skipped if the EXE already exists. This is a common pitfall.

I wasn't implying whether this PR was or wasn't a good direction to pursue. I just wanted to point out that we can't remove the `SHARED_BUILD_TESTCASE`.

I think having fewer footguns is good. So implicit setting seems ok (FWIW we wouldn't have to do that if the `Makefile.rules` supported PDB and we could follow the other STL approach of passing the `#define` into `self.build`...but that's a lot of work, and maybe not even doable).

https://github.com/llvm/llvm-project/pull/190991