[Lldb-commits] [lldb] [lldb] Fix: Disable shared build dir when testing with PDB (PR #190991)

[Michael Buch via lldb-commits]

Michael137 wrote:

> If we agree on this implicit switch, we could remove the explicit setting from the following 24 more test cases (i.e. all PDB-enabled tests). It took me some time to understand the full picture and I'd like to spare others that experience.
> 
> ```
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\atomic\TestDataFormatterStdAtomic.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\deque\TestDataFormatterGenericDeque.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\forward_list\TestDataFormatterGenericForwardList.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\list\TestDataFormatterGenericList.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\list\loop\TestDataFormatterGenericListLoop.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\map\TestDataFormatterStdMap.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\multimap\TestDataFormatterGenericMultiMap.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\multiset\TestDataFormatterGenericMultiSet.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\optional\TestDataFormatterGenericOptional.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\ordering\TestDataFormatterStdOrdering.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\set\TestDataFormatterGenericSet.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\shared_ptr\TestDataFormatterStdSharedPtr.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\span\TestDataFormatterStdSpan.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\string\TestDataFormatterStdString.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\string_view\TestDataFormatterStdStringView.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\tuple\TestDataFormatterStdTuple.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\u8string\TestDataFormatterStdU8String.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\u8string_view\TestDataFormatterStdU8StringView.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\unique_ptr\TestDataFormatterStdUniquePtr.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\unordered\TestDataFormatterGenericUnordered.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\variant\TestDataFormatterStdVariant.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\vbool\TestDataFormatterStdVBool.py
> 
> lldb\test\API\functionalities\data-formatter\data-formatter-stl\generic\vector\TestDataFormatterStdVector.py
> 
> lldb\test\API\test_utils\pdb\TestPdb.py
> 
> ```

I suspect we cant do that because the other STL tests rely on this setting to not share build directories too (it's not just for PDB). But there'll be a Python assertion to catch this if you tried removing it

https://github.com/llvm/llvm-project/pull/190991