[Lldb-commits] [lldb] [lldb] change how unsupported tests are aggregated (PR #185675)

[Charles Zablit via lldb-commits]

charles-zablit wrote:

> Currently if 2 tests are UNSUPPORTED and 1 test is PASS or XFAIL, the aggregated result will be UNSUPPORTED.

This is incorrect sorry, it should be:

> Currently if 2 tests are UNSUPPORTED and 1 test is XFAIL, the aggregated result will be UNSUPPORTED. If any test is PASS, the aggregated result will be PASS.

The change in the diff is explained by the fact that many of the tests on Windows are considered UNSUPPORTED whereas they are really XFAIL.

Maybe this is the wrong solution and instead we should not attempt to run the tests at all on platforms that do not support these tests variants: `dsym` and `dwo` should not be UNSUPPORTED on Windows, they should not even be run in the first place.

> But the `lit_results` makes it seem like that's now possible, so why can't we rely on that and use the exit code to pick between PASS or FAIL?

I don't think returning multiple results is supported yet, the output of the `execute` method is expected to be a tuple with the first element being the return code and the second the output: https://github.com/charles-zablit/llvm-project/blob/4727ed3c09c0765373c426d0059097bc92023c65/llvm/utils/lit/lit/worker.py#L94-L99

https://github.com/llvm/llvm-project/pull/185675