[Lldb-commits] [lldb] [lldb] change how unsupported tests are aggregated (PR #185675)

[Jonas Devlieghere via lldb-commits]

JDevlieghere wrote:

> Currently if 2 tests are UNSUPPORTED and 1 test is PASS or XFAIL, the aggregated result will be UNSUPPORTED.

I had a hard time reconciling that statement with the diff, which previously said that if there's at least one pass, the test returns PASS. Is the issue that it prioritizes the `lit_results` over the return value? If so, why do we have to aggregate anything? If my memory serves me correctly, I did the aggregation at the time because lit didn't support multiple outputs for a single test and we had to do a many-to-one mapping. But the ``lit_results` makes it seem like that's now possible, so why can't we rely on that and use the exit code to pick between PASS or FAIL? In other words, can we do something like this and let lit deal with it?

```
if exitCode: 
    return lit.Test.FAIL, output
else
    return lit.Test.PASS, output
lit_results = [
    (passes, lit.Test.PASS),
    (skipped, lit.Test.UNSUPPORTED),
    (expected_failures, lit.Test.XFAIL),
    (failures, lit.Test.FAIL),
    (errors, lit.Test.UNRESOLVED),
    (unexpected_successes, lit.Test.XPASS),
]
```

https://github.com/llvm/llvm-project/pull/185675