[Lldb-commits] [lldb] [lldb] Don't link TestingSupport as a component (PR #184310)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Nikita Popov (nikic)

<details>
<summary>Changes</summary>

This doesn't work with dylib builds, because TestingSupport is not part of the dylib. Instead, we should link it via LINK_LIBS, like other tests already do.

---
Full diff: https://github.com/llvm/llvm-project/pull/184310.diff


1 Files Affected:

- (modified) lldb/unittests/Target/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/lldb/unittests/Target/CMakeLists.txt b/lldb/unittests/Target/CMakeLists.txt
index 47df8c600ca19..bf08a8f015ba0 100644
--- a/lldb/unittests/Target/CMakeLists.txt
+++ b/lldb/unittests/Target/CMakeLists.txt
@@ -18,7 +18,6 @@ add_lldb_unittest(TargetTests
 
   LINK_COMPONENTS
       Support
-      TestingSupport
   LINK_LIBS
       lldbCore
       lldbHost
@@ -33,6 +32,7 @@ add_lldb_unittest(TargetTests
       lldbSymbol
       lldbUtility
       lldbUtilityHelpers
+      LLVMTestingSupport
   )
 
 set(test_inputs

``````````

</details>


https://github.com/llvm/llvm-project/pull/184310