[Lldb-commits] [lldb] [lldb] Don't link TestingSupport as a component (PR #184310)
Nikita Popov via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 3 01:58:20 PST 2026
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/184310
This doesn't work with dylib builds, because TestingSupport is not part of the dylib. Instead, we should link it via LINK_LIBS, like other tests already do.
>From 9b4786b39a147340fdc1a8562eb3ddbf2fdee432 Mon Sep 17 00:00:00 2001
From: Nikita Popov <npopov at redhat.com>
Date: Tue, 3 Mar 2026 10:56:42 +0100
Subject: [PATCH] [lldb] Don't link TestingSupport as a component
This doesn't work with dylib builds, because TestingSupport is not
part of the dylib. Instead, we should link it via LINK_LIBS, like
other tests already do.
---
lldb/unittests/Target/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/unittests/Target/CMakeLists.txt b/lldb/unittests/Target/CMakeLists.txt
index 47df8c600ca19..bf08a8f015ba0 100644
--- a/lldb/unittests/Target/CMakeLists.txt
+++ b/lldb/unittests/Target/CMakeLists.txt
@@ -18,7 +18,6 @@ add_lldb_unittest(TargetTests
LINK_COMPONENTS
Support
- TestingSupport
LINK_LIBS
lldbCore
lldbHost
@@ -33,6 +32,7 @@ add_lldb_unittest(TargetTests
lldbSymbol
lldbUtility
lldbUtilityHelpers
+ LLVMTestingSupport
)
set(test_inputs
More information about the lldb-commits
mailing list