[Lldb-commits] [lldb] [lldb] Step over non-lldb breakpoints (PR #174348)

[David Spickett via lldb-commits]

================
@@ -1946,146 +1947,147 @@ size_t Platform::ConnectToWaitingProcesses(lldb_private::Debugger &debugger,
   return 0;
 }
 
-size_t Platform::GetSoftwareBreakpointTrapOpcode(Target &target,
-                                                 BreakpointSite *bp_site) {
-  ArchSpec arch = target.GetArchitecture();
-  assert(arch.IsValid());
-  const uint8_t *trap_opcode = nullptr;
-  size_t trap_opcode_size = 0;
+llvm::ArrayRef<uint8_t> Platform::SoftwareTrapOpcodeTable(const ArchSpec &arch,
----------------
DavidSpickett wrote:

The Table part of SoftwareTrapOpcodeTable doesn't make sense to me (at least, half way through this review it didn't). Since it only returns one encoding.

If we returned a table indexed by encoding size, then sure, Table makes sense.

https://github.com/llvm/llvm-project/pull/174348