[Lldb-commits] [lldb] [lldb] Step over non-lldb breakpoints (PR #174348)

[David Spickett via lldb-commits]

================
@@ -138,6 +138,17 @@ class Architecture : public PluginInterface {
       std::shared_ptr<const UnwindPlan> current_unwindplan) {
     return lldb::UnwindPlanSP();
   }
+
+  /// Returns whether a given byte sequence is a valid breakpoint for the
+  /// architecture. Some architectures have breakpoint instructions that
+  /// have immediates that can take on any value, resulting in a family
+  /// of valid byte sequences. Bases the size comparison on the reference.
----------------
DavidSpickett wrote:

> Bases the size comparison on the reference.

I'm not sure what point you're making with this. Perhaps you are saying that if the sizes do not match, the result is false, even if some of the first bytes do happen to match?

https://github.com/llvm/llvm-project/pull/174348