[Lldb-commits] [lldb] [lldb] Use AST nodes as Subscript and BitField arguments in DIL (PR #169363)

[Ilia Kuklin via lldb-commits]

kuilpd wrote:

> Just one remaining question about a null-check left, but otherwise LGTM

Thank you for reviewing!

If you mean null-checking the result of `Evaluate`, in the previous patch I added the check inside `Evaluate` that converts a null `ValueObjectSP` to an error, so we don't have to check its result again every time.
https://github.com/llvm/llvm-project/blob/6beba5c3ef52a2bf48c3709eb46084ef276a7edb/lldb/source/ValueObject/DILEval.cpp#L245-L248

https://github.com/llvm/llvm-project/pull/169363