[Lldb-commits] [lldb] [lldb] Use AST nodes as Subscript and BitField arguments in DIL (PR #169363)

[Ilia Kuklin via lldb-commits]

================
@@ -11,14 +11,6 @@
 class TestFrameVarDILArraySubscript(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
-    def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None):
----------------
kuilpd wrote:

I'm not quite sure, to be honest. We made the comparisons while developing the same functionality as in old `frame var` so that we wouldn't have to check the results manually. But once we implemented everything it kind of lost its purpose, since all the cases are already tested on a confirmed result. If there's a new bug in DIL, the test would fail whether it is checked against old `frame var` or not. Only a couple of existing tests still have this function.

https://github.com/llvm/llvm-project/pull/169363