[Lldb-commits] [lldb] [lldb] support breakpoint by name on abi_tagged functions (PR #170527)

[Ebuka Ezike via lldb-commits]

================
@@ -538,15 +539,156 @@ void CPlusPlusLanguage::CxxMethodName::Parse() {
   }
 }
 
-llvm::StringRef
-CPlusPlusLanguage::CxxMethodName::GetBasenameNoTemplateParameters() {
-  llvm::StringRef basename = GetBasename();
-  size_t arg_start, arg_end;
-  llvm::StringRef parens("<>", 2);
-  if (ReverseFindMatchingChars(basename, parens, arg_start, arg_end))
-    return basename.substr(0, arg_start);
+bool CPlusPlusLanguage::CxxMethodName::NameMatches(llvm::StringRef full_name,
+                                                   llvm::StringRef pattern,
+                                                   MatchOptions options) {
+  constexpr llvm::StringRef abi_prefix = "[abi:";
----------------
da-viper wrote:

the abi_tag may be in the template i.e `Module<SomeType[abi:TAG]>::find` and will fail. 
and we also compare the tag names in case in the future we add support for `breakpoint set --name foo[abi:TAG]` 

https://github.com/llvm/llvm-project/pull/170527