[Lldb-commits] [lldb] [lldb] support breakpoint by name on abi_tagged functions (PR #170527)

[Greg Clayton via lldb-commits]

================
@@ -538,15 +539,156 @@ void CPlusPlusLanguage::CxxMethodName::Parse() {
   }
 }
 
-llvm::StringRef
-CPlusPlusLanguage::CxxMethodName::GetBasenameNoTemplateParameters() {
-  llvm::StringRef basename = GetBasename();
-  size_t arg_start, arg_end;
-  llvm::StringRef parens("<>", 2);
-  if (ReverseFindMatchingChars(basename, parens, arg_start, arg_end))
-    return basename.substr(0, arg_start);
+bool CPlusPlusLanguage::CxxMethodName::NameMatches(llvm::StringRef full_name,
+                                                   llvm::StringRef pattern,
+                                                   MatchOptions options) {
+  constexpr llvm::StringRef abi_prefix = "[abi:";
----------------
clayborg wrote:

Can we simplify the changes to this code by splitting the "full_name" like:
```
// Remove any encoded ABI tags from the C++ name before looking for matches
full_name = full_name.split("[abi::").first;
```
Then nothing else in this function needs to change right? Or are we trying to do something with the ABI name later?

https://github.com/llvm/llvm-project/pull/170527